feat(rel): change build names for single image#130
Merged
jdpleiness merged 1 commit intomainfrom Dec 18, 2024
Merged
Conversation
Images are no longer sized so remove duplicate builds and remove image size in description and name
Chickensoupwithrice
approved these changes
Dec 18, 2024
| @@ -392,10 +392,10 @@ build { | |||
| name = "sourcegraph-amis" | |||
| sources = var.dev ? ["source.amazon-ebs.DEV"] : [ | |||
| "source.amazon-ebs.XS", | |||
Contributor
There was a problem hiding this comment.
shouldn't we get rid of this one too?
Contributor
There was a problem hiding this comment.
Oh wait, that's the only one left that doesn't need sizing anymore. I see
Contributor
Author
There was a problem hiding this comment.
Yeah I'll go in here and do some cleanup after. This is just getting it out the door for today.
jdpleiness
deleted the
jdp/rel/change-build-names-for-burstable-QOS-prep
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images are no longer sized so remove duplicate builds and remove image size in description and name